Document expired - small bug and "workaround" - LetoDMS 3.0.0 Stable.

[rduarte]

Hello LetoDMS team,

We had tested document expiration in 3.0.0 Stable version and found a little problem:

When a document have a reviewer/approver and expires without an action by any people, clicking on name of this document on "My documents" cause IE or Firefox error.

Logs from Apache shows:

===================================================
[Fri May 20 12:52:04 2011] [error] [client 192.168.0.20] PHP Warning: Missing argument 3 for LetoDMS_Core_DocumentContent:etStatus(), cal
led in /srv/www/vhosts/ged/LetoDMS_Core/Core/inc.ClassDocument.php on line 429 and defined in /srv/www/vhosts/ged/LetoDMS_Core/Core/inc.Clas
sDocument.php on line 1657, referer: http://ged.mysite.com.br/out/out.MyDocum...nProcess=1

[Fri May 20 12:52:04 2011] [error] [client 192.168.0.20] PHP Notice: Undefined variable: updateUser in /srv/www/vhosts/ged/LetoDMS_Core/Cor
e/inc.ClassDocument.php on line 1661, referer: http://ged.mysite.com.br/out/out.MyDocum...nProcess=1
===================================================



Looking at line 429 on /srv/www/vhosts/ged/LetoDMS_Core/Core/inc.ClassDocument.php , we set the "return" line/variable to "false" and gain a "workaround" for this problem.




See how we made:

=======================================================
if (($st["status"]==S_DRAFT_REV || $st["status"]==S_DRAFT_APP) && $this->hasExpired()){
$lc->setStatus(S_EXPIRED,"");
// return true;
return false;
}
=======================================================


Thanks !

Roberto C. Duarte
rduarte<at>rcdtecnologia.com.br